Updating Hello World example CMakeLists #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kheaactua
reviewed
Aug 13, 2024
kheaactua
reviewed
Aug 13, 2024
kheaactua
reviewed
Aug 13, 2024
kheaactua
reviewed
Aug 13, 2024
kheaactua
reviewed
Aug 13, 2024
kheaactua
reviewed
Aug 14, 2024
kheaactua
reviewed
Aug 14, 2024
|
I cherry picked your commit with my updates to them here: https://github.com/COVESA/vsomeip/pull/734/files#diff-3cd5bfd22b6c516e2683d8c9bf7a9c832e022109aad0a1eaf826debb82150480 No idea what the timeline of this PR will be though |
kheaactua
reviewed
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the CMakeLists for the use of target_compile_features function and did a small refactor to avoid duplicate code.
Details
Suggested from a COVESA comment (link),
tried to update the setting of c++17 flag.
To use target_compile_features it would lead to more duplicate code.
Instead, two functions were created to reduce that. There is no impact on the code in itself.
Issue
None