main_phase_timer should be stopped along with SD #740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
main_phase_timer
isn't stopped, it might preventroutingmanagerd
from quitting gracefully. Thread will be blocked onjoin()
.This is a followup on #559. The issue is a sporative (through rare)
SIGTERM
on exit fromroutingmanagerd
.The key signature of the crash appears to be:
That PR inverted the ownership structure in SD (better explained by @vvcarvalho here.) This change however calls a stop on
main_phase_timer
during shutdown.