-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signals for Motion Management #785
Conversation
Signed-off-by: Erik Jaegervall <[email protected]>
You mean invite them October? I assume not September NEXT year? |
Oh dear, is it already October? |
I was wondering, with these "more specialized" VSS areas, should we give easy options (i.e. via overlay) to ONLY transform this branch, or maybe even formulate this as a self contained tree (and thus potential overlay). Don't get me wrong, I think it is very cool to extend VSS in this direction, and instead of blocking this with another half year discussion, let's rather check and merge it. I am just thinking that the criteria for "generally useful" when deciding what to add later are different from the VehicleMotion Branch compared to the whole tree (or let's say infotainment), so maybe it is the time to have the moduels/profiles/composable stndnard model discussion again. |
Concerning separate signals for target values (as discussed in last meeting) we had some previous discussion in #744. In cases where there could be more advanced logic before deciding what to request from the real actuator we have often used separate signals, like a separate signal for target cruise control speed. With that approach, if one just see vehicle motion management as an "optional system", it sort of makes sense to use separate signals. Maybe the driver has the ability to disable the vehicle motion system, and then the drive train and brakes will react directly based on pedal position. I.e. vehicle motion system cannot directly control brakes and electrical engine. So I think one need to check in individual cases if we think that having a traditional "dual usage" actuator makes sense. |
MoM:
|
MoM:
|
MoM: Merge |
This is a proposal to add a number of signals for vehicle motion management, for instance making sure that vehicle stability is maintained during braking and when turning. As this is somewhat complex area it is also proposed to add a page in documentation to describe possible usage.
I will invite subject matter experts to the VSS meetings October 22nd and 29th so that they can give background to the change and answer questions.