Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove submodule (version 2) #778

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Sep 17, 2024

An alternative to #768

I did some more changes which I think would make sense to introduce for the upcoming 5.0, in short building on what Mr Schildt already have done.

In short - adding a release workflow that triggers build and uploads what we want to upload. Also removing the VERSION file as I do not really see that it is needed and using generic names for build artifacts making handling easier.

An example on how this could affect release handling.

  • If we want to release a v1.6rc0 from master then we trigger the Draft release workflow stating 1.6.rc0 as version.
  • That will build all artifacts and upload them to a draft release
  • When publishing the release source code is added and tagging performed and we get something like https://github.com/erikbosch/vehicle_signal_specification/releases/tag/v1.6rc0
  • (In a real release we should update release notes before publishing)

@erikbosch erikbosch added the Release Blocker PR suggested to be merged before releasing label Sep 17, 2024
@erikbosch erikbosch changed the title Erik remove submodule Remove submodule (version 2) Sep 17, 2024
@erikbosch erikbosch marked this pull request as ready for review September 17, 2024 14:02
@erikbosch
Copy link
Collaborator Author

MoM:

  • Presented
  • Erik and Sebastian to agree on what to include for 5.0

@erikbosch
Copy link
Collaborator Author

I will include this one for 5.0 as it seems to work for the 5.0 needs. The other PR (#768) can then be seen as an add-on for 5.1 to introduce matrix builds.

@erikbosch erikbosch merged commit 1f4fa48 into COVESA:master Sep 19, 2024
7 checks passed
@erikbosch erikbosch deleted the erik_remove_submodule branch September 19, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker PR suggested to be merged before releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants