Skip to content

Commit

Permalink
Align Temperature Signals
Browse files Browse the repository at this point in the history
As of today we have a mix of float and int16 for temperature signals,
with no real rationale for the difference. This PR changes the int16 signals
to instead use float, so after this change all signals with Celisus unit use float.

Only intended for VSS 5.0 as this is a backward incompatible change.

Signed-off-by: Erik Jaegervall <[email protected]>
  • Loading branch information
erikbosch committed Nov 14, 2023
1 parent 337679b commit 3ec3c25
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions spec/Powertrain/CombustionEngine.vspec
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ IdleHours:
# Engine coolant temperature
#
ECT:
datatype: int16
datatype: float
type: sensor
unit: celsius
description: Engine coolant temperature.
Expand All @@ -163,7 +163,7 @@ ECT:
# Engine Oil Temperature
#
EOT:
datatype: int16
datatype: float
type: sensor
unit: celsius
description: Engine oil temperature.
Expand Down
4 changes: 2 additions & 2 deletions spec/Powertrain/ElectricMotor.vspec
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Speed:
# Motor temperature
#
Temperature:
datatype: int16
datatype: float
type: sensor
unit: celsius
description: Motor temperature.
Expand All @@ -67,7 +67,7 @@ Temperature:
# Motor coolant temperature (if applicable)
#
CoolantTemperature:
datatype: int16
datatype: float
type: sensor
unit: celsius
description: Motor coolant temperature (if applicable).
Expand Down
2 changes: 1 addition & 1 deletion spec/Powertrain/Transmission.vspec
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ GearChangeMode:
# Gearbox temperature
#
Temperature:
datatype: int16
datatype: float
type: sensor
unit: celsius
description: The current gearbox temperature.
Expand Down

0 comments on commit 3ec3c25

Please sign in to comment.