-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert Rename of dlt_common. (#512)" #513
base: master
Are you sure you want to change the base?
Conversation
reopened |
Thanks, i reverted already with this PR #512 |
So, can you please explain what broke? We should really convert it into a c++ file, if containing c++ code, right? |
@LocutusOfBorg Sorry i have not much tiem at the moment. The Windows build was not working, thats why i have reverted it. If you can also have a look into Windows would be nice. |
@alexmucde does the pipeline have some link? I don't have any windows machine, nor I know how to build, but if the pipeline runs on GitHub I can try to fix... |
2990cc1
to
3ccadad
Compare
@alexmucde can you please try this solution instead? It fixes the build for me |
8ac842e
to
524227d
Compare
@LocutusOfBorg I get the following error: Bibliothek "..\release\qdlt.lib" und Objekt "..\release\qdlt.exp" werden erstellt. |
The following line is missing in qdlt.pro: win32:LIBS += User32.lib This is already integrated in the master. |
is it ok now? I did sync master |
@LocutusOfBorg Sorry, we have some conflicts now. |
3573bd9
to
fb38e22
Compare
Rebased, I admit after #594 this is not useful anymore, but we can still simplify somewhere the speed_t definition in one single place, to have better code and more clean |
This reverts commit a3ad76c.