Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker desktop link #45

Closed
wants to merge 4 commits into from
Closed

fix docker desktop link #45

wants to merge 4 commits into from

Conversation

chrizmc
Copy link
Collaborator

@chrizmc chrizmc commented May 21, 2024

fixed
#41

@slawr slawr linked an issue May 21, 2024 that may be closed by this pull request
@slawr slawr self-assigned this May 21, 2024
Copy link
Collaborator

@slawr slawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think originally I had the link to Docker Desktop in the docker doc site but this also works and takes you to the former if you follow doc links on the page. So happy to merge.

Copy link
Collaborator

@slawr slawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was preparing to merge then realised you are missing a signed-off in the commit msg. Please update with one to conform with the COVESA submission policy.

You can do that by simply amending the local commit and force pushing your PR to your rep. Reach out if you need guidance.

@slawr slawr assigned chrizmc and unassigned slawr May 21, 2024
@slawr slawr added bug Something isn't working documentation Improvements or additions to documentation labels May 21, 2024
@slawr
Copy link
Collaborator

slawr commented May 24, 2024

Pull request was superseded by PR #46 . Therefore closing this PR

@slawr slawr closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Wrong link in readme for docker desktop
2 participants