Convert first person singular to first person plural in a recipe #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I find that most people don't review or respond to my review requests so I tend to assign always PRs to @julia-neme and @adele-morrison. Sorry for that @julia-neme and @adele-morrison, but also THANKS! |
navidcy
changed the title
julia-neme
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recipe had sprinkled "I choose to do this", "I plot that" and I was confused. First of all I didn't know who "I" was but also it felt a bit alienating. I converted to "we...".
Also there was a claim that some cells would take 20min; it took 1 min for me. I removed the claim. The timing on the cells is self explanatory. There was another commented text and a claim that "I tested this recipe using these other examples" but since we can't ensure that is true as time moves on I rephrased it to something a bit less concrete.