Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to MMDF #9

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Small changes to MMDF #9

merged 6 commits into from
Mar 5, 2024

Conversation

stelmo
Copy link
Member

@stelmo stelmo commented Feb 1, 2024

No description provided.

@stelmo
Copy link
Member Author

stelmo commented Feb 1, 2024

/format

@stelmo stelmo requested a review from exaexa February 1, 2024 15:31
@stelmo
Copy link
Member Author

stelmo commented Feb 1, 2024

Not sure if the plotting is worth it here, can revert?

Copy link
Contributor

github-actions bot commented Feb 1, 2024

✔️ Auto-formatting triggered by this comment succeeded, commited as d0853da

github-actions bot pushed a commit that referenced this pull request Feb 1, 2024
triggered by @stelmo on PR #9
@stelmo
Copy link
Member Author

stelmo commented Feb 1, 2024

Need some way to tell the testing interface to ignore the plotting calls. Maybe plotting is not worth it here, but it could be nice to show plots in the showcase examples

stelmo added a commit that referenced this pull request Feb 1, 2024
triggered by @stelmo on PR #9
@exaexa exaexa changed the base branch from sew-move-log-conc to master February 2, 2024 09:12
@exaexa
Copy link
Member

exaexa commented Feb 2, 2024

rebasegun applied

@stelmo
Copy link
Member Author

stelmo commented Feb 2, 2024

Took out the plotting, should be g2g now @exaexa

Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrote a bit closer to the original form, avoiding a few gotchas here and there. Most notably the ConstraintTree is now really tiny, which is cool

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@exaexa exaexa merged commit dbb447e into master Mar 5, 2024
4 checks passed
@exaexa exaexa deleted the sew-improve-mmdf branch March 5, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants