simplify unsigned constraints a bit #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without any extra treatment, this uses 2 variables + 6 inequality constraints per a split variable with 2 constraints. Which is a bit of an improvement from the original 3 variables + 6 inequality constraints + 1 equality constraint. Additionally, 2 of the new 6 inequality constraints are redundant and may be removed manually.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 576 584 +8
=========================================
+ Hits 576 584 +8 ☔ View full report in Codecov by Sentry. |
stelmo
reviewed
Nov 12, 2024
missed that one, should be complete now. Test coverage gonna suffer though, will need to add some creativity later. |
|
I added a standalone example to cover the variable splitting possibilities. |
stelmo
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without any extra treatment, this uses 2 variables + 6 inequality constraints per a split variable with 2 constraints. Which is a bit of an improvement from the original 3 variables + 6 inequality constraints + 1 equality constraint.
Additionally, 2 of the new 6 inequality constraints are redundant and may be removed manually.
Probably needs tests and a coverage fix.