Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SMoment #12

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Implement SMoment #12

merged 8 commits into from
Mar 7, 2024

Conversation

stelmo
Copy link
Member

@stelmo stelmo commented Feb 2, 2024

No description provided.

@stelmo
Copy link
Member Author

stelmo commented Feb 2, 2024

/format

Copy link
Contributor

github-actions bot commented Feb 2, 2024

✔️ Auto-formatting triggered by this comment succeeded, commited as c4a9011

github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
triggered by @stelmo on PR #12
stelmo added a commit that referenced this pull request Feb 2, 2024
triggered by @stelmo on PR #12
@stelmo stelmo requested a review from exaexa February 2, 2024 19:47
stelmo added a commit that referenced this pull request Feb 2, 2024
triggered by @stelmo on PR #12
@stelmo stelmo force-pushed the sew-smoment branch 2 times, most recently from 814a5cb to abb7916 Compare February 2, 2024 20:40
Base automatically changed from sew-enzyme-constraints to master March 6, 2024 13:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.25%. Comparing base (c93e99f) to head (a631fb8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   54.98%   59.25%   +4.26%     
==========================================
  Files          37       37              
  Lines         391      427      +36     
==========================================
+ Hits          215      253      +38     
+ Misses        176      174       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get this in now, we can live with it. OTOH this should be reworked. Esp the reaction groups IMO don't make any sense, we can do much better.

@exaexa exaexa merged commit 1a62587 into master Mar 7, 2024
4 checks passed
@exaexa exaexa deleted the sew-smoment branch March 7, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants