Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionalize constraint builder for enzymes #11

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

stelmo
Copy link
Member

@stelmo stelmo commented Feb 1, 2024

No description provided.

@stelmo stelmo changed the base branch from mk-frontend-cleaning to sew-fix-unsigned February 1, 2024 19:14
@exaexa exaexa changed the base branch from sew-fix-unsigned to master February 2, 2024 09:16
@exaexa
Copy link
Member

exaexa commented Feb 2, 2024

rebased

Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good, I'll have a look and finish the small things.

@stelmo
Copy link
Member Author

stelmo commented Feb 2, 2024

/format

Copy link
Contributor

github-actions bot commented Feb 2, 2024

✔️ Auto-formatting triggered by this comment succeeded, commited as 2d20619

github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
triggered by @stelmo on PR #11
@stelmo
Copy link
Member Author

stelmo commented Feb 2, 2024

Okay, this is bug free now :) will implement smoment from this point

@stelmo stelmo requested a review from exaexa February 2, 2024 18:36
Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split this into proper variables and constraints. look ok now

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@173c0aa). Click here to learn what that means.

Files Patch % Lines
src/frontend/enzymes.jl 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage          ?   54.98%           
=========================================
  Files             ?       37           
  Lines             ?      391           
  Branches          ?        0           
=========================================
  Hits              ?      215           
  Misses            ?      176           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa exaexa merged commit c93e99f into master Mar 6, 2024
4 checks passed
@exaexa exaexa deleted the sew-enzyme-constraints branch March 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants