Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge individual changes to public/src/modules/settings.js from project 1 #16

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

annashiheart
Copy link

Merging individual changes from Project 1 into team repository.
Reduced the cognitive complexity of the fillFields function in public/src/modules/settings.js by creating a helper function updateValues that updates all the values in the input fields of the form.

UI Test

  1. Log into admin
  2. Navigate to settings page under admin
  3. Type something in the form input fields
  4. Save changes

Copy link

@evelynnchen-cmu evelynnchen-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annashiheart To resolve merge conflicts, please delete dump.rdb. Everything else looks good to me.

@annashiheart annashiheart merged commit c8357d6 into f24 Sep 22, 2024
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10981641683

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.685%

Totals Coverage Status
Change from base Build 10975470003: 0.005%
Covered Lines: 22331
Relevant Lines: 25587

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants