Add slither report

CMTA · Sep 3, 2024 · 15ffbe4 · 15ffbe4
1 parent 5d3155d
commit 15ffbe4
Show file tree

Hide file tree

Showing 4 changed files with 91 additions and 6 deletions.
diff --git a/doc/slither-report.md b/doc/slither-report.md
@@ -0,0 +1,85 @@
+**THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results.
+Summary
+ - [solc-version](#solc-version) (1 results) (Informational)
+ - [similar-names](#similar-names) (9 results) (Informational)
+## solc-version
+
+> The version in the config file is 0.8.26
+
+Impact: Informational
+Confidence: High
+ - [ ] ID-0
+	Version constraint ^0.8.20 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
+	- VerbatimInvalidDeduplication
+	- FullInlinerNonExpressionSplitArgumentEvaluationOrder
+	- MissingSideEffectsOnSelectorAccess.
+	 It is used by:
+	- lib/CMTAT/contracts/interfaces/IDebtGlobal.sol#3
+	- lib/CMTAT/contracts/interfaces/engine/IDebtEngine.sol#3
+	- lib/openzeppelin-contracts/contracts/access/AccessControl.sol#4
+	- lib/openzeppelin-contracts/contracts/access/IAccessControl.sol#4
+	- lib/openzeppelin-contracts/contracts/utils/Context.sol#4
+	- lib/openzeppelin-contracts/contracts/utils/introspection/ERC165.sol#4
+	- lib/openzeppelin-contracts/contracts/utils/introspection/IERC165.sol#4
+	- src/DebtEngine.sol#2
+	- src/DebtEngineInvariantStorage.sol#2
+
+## similar-names
+
+> Acknowledge
+
+Impact: Informational
+Confidence: Medium
+ - [ ] ID-1
+Variable [DebtEngine.debt(address).smartContract_](src/DebtEngine.sol#L36) is too similar to [DebtEngine.setDebtBatch(address[],IDebtGlobal.DebtBase[]).smartContracts](src/DebtEngine.sol#L89)
+
+src/DebtEngine.sol#L36
+
+
+ - [ ] ID-2
+Variable [DebtEngine.setCreditEvents(address,IDebtGlobal.CreditEvents).smartContract_](src/DebtEngine.sol#L69) is too similar to [DebtEngine.setDebtBatch(address[],IDebtGlobal.DebtBase[]).smartContracts](src/DebtEngine.sol#L89)
+
+src/DebtEngine.sol#L69
+
+
+ - [ ] ID-3
+Variable [DebtEngine.creditEvents(address).smartContract_](src/DebtEngine.sol#L51) is too similar to [DebtEngine.setDebtBatch(address[],IDebtGlobal.DebtBase[]).smartContracts](src/DebtEngine.sol#L89)
+
+src/DebtEngine.sol#L51
+
+
+ - [ ] ID-4
+Variable [DebtEngine.debt(address).smartContract_](src/DebtEngine.sol#L36) is too similar to [DebtEngine.setCreditEventsBatch(address[],IDebtGlobal.CreditEvents[]).smartContracts](src/DebtEngine.sol#L76)
+
+src/DebtEngine.sol#L36
+
+
+ - [ ] ID-5
+Variable [DebtEngine.setDebt(address,IDebtGlobal.DebtBase).smartContract_](src/DebtEngine.sol#L62) is too similar to [DebtEngine.setCreditEventsBatch(address[],IDebtGlobal.CreditEvents[]).smartContracts](src/DebtEngine.sol#L76)
+
+src/DebtEngine.sol#L62
+
+
+ - [ ] ID-6
+Variable [DebtEngine.setDebt(address,IDebtGlobal.DebtBase).smartContract_](src/DebtEngine.sol#L62) is too similar to [DebtEngine.setDebtBatch(address[],IDebtGlobal.DebtBase[]).smartContracts](src/DebtEngine.sol#L89)
+
+src/DebtEngine.sol#L62
+
+
+ - [ ] ID-7
+Variable [DebtEngine.creditEvents(address).smartContract_](src/DebtEngine.sol#L51) is too similar to [DebtEngine.setCreditEventsBatch(address[],IDebtGlobal.CreditEvents[]).smartContracts](src/DebtEngine.sol#L76)
+
+src/DebtEngine.sol#L51
+
+
+ - [ ] ID-8
+Variable [DebtEngine.setCreditEvents(address,IDebtGlobal.CreditEvents).smartContract_](src/DebtEngine.sol#L69) is too similar to [DebtEngine.setCreditEventsBatch(address[],IDebtGlobal.CreditEvents[]).smartContracts](src/DebtEngine.sol#L76)
+
+src/DebtEngine.sol#L69
+
+
+ - [ ] ID-9
+Variable [DebtEngine._creditEvents](src/DebtEngine.sol#L12) is too similar to [DebtEngine.setCreditEvents(address,IDebtGlobal.CreditEvents).creditEvents_](src/DebtEngine.sol#L69)
+
+src/DebtEngine.sol#L12
+
diff --git a/src/DebtEngine.sol b/src/DebtEngine.sol
@@ -1,5 +1,5 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+// SPDX-License-Identifier: MPL-2.0
+pragma solidity ^0.8.20;
 
 import "OZ/access/AccessControl.sol";
 import "CMTAT/interfaces/engine/IDebtEngine.sol";

diff --git a/src/DebtEngineInvariantStorage.sol b/src/DebtEngineInvariantStorage.sol
@@ -1,5 +1,5 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+// SPDX-License-Identifier: MPL-2.0
+pragma solidity ^0.8.20;
 
 contract  DebtEngineInvariantStorage {
     // CreditEvents

diff --git a/test/DebtEngine.t.sol b/test/DebtEngine.t.sol
@@ -1,5 +1,5 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+// SPDX-License-Identifier: MPL-2.0
+pragma solidity ^0.8.20;
 
 import "forge-std/Test.sol";
 import "../src/DebtEngine.sol";