Optimisations, CI workflow, & deploy script #190
Conversation
* For loops and function arguments optimization * Substitute require statements with custom errors
* Add deploy script for CMTAT --------- Co-authored-by: Diego G <[email protected]>
|
Thank you very much for your great work. For the custom errors, I saw that currently there is no support of it with truffle/ganache for the tests ("expectRevert.unspecified"). |
Yes, we already discussed the same topic internally. We preferred to include the optimisation because it's significant enough. This TODO in the code should be addressed as soon as Truffle implements the feature. I will open an issue to remember it. |
|
Ok perfect, thank you for your work Perhaps it will be possible to test that with Foundry if one day the actual tests are updated. I think we can add the support of custom errors for the future version 2.4. The version 2.3 will be an audited version, recommended by the CMTA, and I am not really comfortable by adding a functionality which is not audited and not entirely tested. So here the "planning":
|
Closes #189 , #188 , #133