Add slither report for the version 2.3.1

CMTA · Sep 13, 2023 · 166fe25 · 166fe25
1 parent 95fef65
commit 166fe25
Show file tree

Hide file tree

Showing 6 changed files with 239 additions and 209 deletions.
diff --git a/contracts/CMTAT_PROXY.sol b/contracts/CMTAT_PROXY.sol
@@ -13,8 +13,6 @@ contract CMTAT_PROXY is CMTAT_BASE {
     constructor(
         address forwarderIrrevocable
     ) MetaTxModule(forwarderIrrevocable) {
-        // Initialize the variable for the implementation
-        deployedWithProxy = true;
         // Disable the possibility to initialize the implementation
         _disableInitializers();
     }

diff --git a/contracts/modules/internal/ERC20SnapshotModuleInternal.sol b/contracts/modules/internal/ERC20SnapshotModuleInternal.sol
@@ -51,7 +51,9 @@ abstract contract ERC20SnapshotModuleInternal is ERC20Upgradeable {
     /**
     @dev time instead of a counter for OpenZeppelin
     */
+    // Initialized to zero
     uint256 private _currentSnapshotTime;
+    // Initialized to zero
     uint256 private _currentSnapshotIndex;
 
     /** 
@@ -74,8 +76,8 @@ abstract contract ERC20SnapshotModuleInternal is ERC20Upgradeable {
     }
 
     function __ERC20Snapshot_init_unchained() internal onlyInitializing {
-        _currentSnapshotTime = 0;
-        _currentSnapshotIndex = 0;
+        // Nothing to do
+        // _currentSnapshotTime & _currentSnapshotIndex are initialized to zero
     }
 
     /** 
@@ -470,6 +472,7 @@ abstract contract ERC20SnapshotModuleInternal is ERC20Upgradeable {
         ) {
             return (0, currentArraySize);
         }
+        // mostRecent is initialized in the loop
         uint256 mostRecent;
         index = currentArraySize;
         for (uint256 i = _currentSnapshotIndex; i < currentArraySize; ) {

diff --git a/contracts/modules/wrapper/core/BaseModule.sol b/contracts/modules/wrapper/core/BaseModule.sol
@@ -13,8 +13,6 @@ abstract contract BaseModule is AuthorizationModule {
     Get the current version of the smart contract
     */
     string public constant VERSION = "2.3.1";
-    // to initialize inside the implementation constructor when deployed with a Proxy
-    bool internal deployedWithProxy;
     /* Events */
     event Term(string indexed newTermIndexed, string newTerm);
     event TokenId(string indexed newTokenIdIndexed, string newTokenId);

diff --git a/contracts/test/CMTATSnapshot/CMTATSnapshotProxyTest.sol b/contracts/test/CMTATSnapshot/CMTATSnapshotProxyTest.sol
@@ -13,8 +13,6 @@ contract CMTATSnapshotProxyTest is CMTAT_BASE_SnapshotTest {
     constructor(
         address forwarderIrrevocable
     ) MetaTxModule(forwarderIrrevocable) {
-        // Initialize the variable for the implementation
-        deployedWithProxy = true;
         // Disable the possibility to initialize the implementation
         _disableInitializers();
     }

diff --git a/doc/audits/tools/slither-report.md → doc/audits/tools/v2.3.0-slither-report.md b/doc/audits/tools/slither-report.md → doc/audits/tools/v2.3.0-slither-report.md