Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added symlinks to sync ntuples #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thomas-mueller
Copy link

What do you think of adding symlinks to the sync ntuples to this repository (instead of only listing the files in some text files)? This makes plotting and comparing the files much more easy.

@gitytakahas
Copy link
Contributor

Hi Thomas, all,

Thanks for this!
Can I ask you one thing ? when we update our trees in the future, we need to update both the text file and this symbolic link ?
If so, I would prefer to fed the text file into compare.py and the script will automatically read the filename from it. Then, we can let one go.

What do you think ?
If you agree, I can implement this ...

Thanks,
Yuta

@thomas-mueller
Copy link
Author

Hi Yuta,

I rather thought the other way round that the link in the text file can become obsolete. But I did not know, that the compare script depends on this link. I agree that maintaining two things for the same is also bad. A solution containing symlinks would be to fix the names of them in the repo such that they could be hardcoded in the compare script. I do not know, if this would be good/acceptable.

Cheers,
Thomas

@gitytakahas
Copy link
Contributor

Hi Thomas,

No, the compare.py script does not depend on this link.
So your idea is to hard-code the file name in compare.py, and keeping symbolic link up to date ?
(and also update the text file accordingly) ?

Thanks,
Yuta

@thomas-mueller
Copy link
Author

I did not want to make it more complicated as it is. I just found it uncomfortable parsing paths from the content of text files (when there is an option to have normal files (here symlinks) instead). If the group is already used to the text files and has the parsing tools at hand, just forget about my change.

@steggema
Copy link
Member

Hi Thomas,
I've changed the compare script such that it can also take txt files as input, from which it takes the first line starting with "/afs" as the location of the root file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants