First pass at removing Boost library dependencies #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces various Boost utilities with standard library equivalents where possible. The changes here are all the pieces that have straightforward replacements. Remaining uses outside of this PR and #164: * `G3Units`: replace preprocessor macros in python binding code with something better in a separate PR * `boost::math::quaternions`: Will be replaced with a native G3FrameObject implementation in a separate PR * `boost::filesystem`: Can be easily replaced with `std::filesystem`, but requires C++17. * `boost::iostreams`: Intertwined with serialization and python bindings * `boost::python`: Yes.
cnweaver
requested changes
Oct 18, 2024
cnweaver
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces various Boost utilities with standard library equivalents where possible. The changes here are all the pieces that have straightforward replacements. Remaining uses outside of this PR:
boost::math::quaternion: Replaced with a native G3FrameObject implementation in a separate PR (see Native quaternion implementation #166)boost::filesystem: Can be easily replaced withstd::filesystem, but requires C++17.boost::iostreams: Intertwined with serialization and python bindings, but the implementation is now entirely contained in core/dataio.cxx/h (see Consolidate IO stream handling in one place #164)boost::python: Yes.