Optionally ignore wiring information in HousekeepingConsumer #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables running the HousekeepingConsumer alongside a Wiring frame generated from a hardware map using the WiringMapInjector.
|
Looks good to me from a code point of view. Does hidfmux not provide an in-band hardware map interface? Having one for the 3G electronics was a huge reliability win. |
|
Hidfmux has the same interfaces as pydfmux for this purpose. This PR just allows constructing the wiring map from the hidfmux HWM while also getting housekeeping frames, where the HWM on-board storage isn't (yet) a standard part of the initialization procedure. |
|
Makes sense. So, my one comment: could you have the code emit a warning if this mode is on that the data could be internally inconsistent if care is not taken? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables running the HousekeepingConsumer alongside a Wiring frame generated from a hardware map using the WiringMapInjector.