Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a read-only current_file attribute for G3MultiFileWriter #155

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add a read-only current_file attribute for G3MultiFileWriter #155

merged 1 commit into from
Apr 25, 2024
+47 −9

Conversation

arahlin
Copy link
Member

@arahlin arahlin commented Apr 25, 2024

This is useful for subclassing this writer for, e.g. writing files to the grid.

@arahlin
Add a read-only current_file attribute for G3MultiFileWriter
b60f51e 
This is useful for subclassing this writer for, e.g. writing files to the grid.
@arahlin arahlin requested a review from nwhitehorn April 25, 2024 20:20
@arahlin arahlin self-assigned this Apr 25, 2024
nwhitehorn
nwhitehorn approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@nwhitehorn nwhitehorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This feature should have been in from the beginning.

@arahlin arahlin merged commit f2d8079 into master Apr 25, 2024
1 check passed
@arahlin arahlin deleted the multi_writer_file branch April 25, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwhitehorn nwhitehorn nwhitehorn approved these changes

Assignees

@arahlin arahlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arahlin @nwhitehorn