Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum cmake version to 3.5 #150

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Update minimum cmake version to 3.5 #150

merged 2 commits into from
Apr 25, 2024

Conversation

arahlin
Copy link
Member

@arahlin arahlin commented Mar 4, 2024

The latest version of cmake (3.28.3) warns that versions < 3.5 will not be supported in the near future.

The latest version of cmake (3.28.3) warns that versions < 3.5 will not be
supported in the near future.
@arahlin arahlin requested review from cnweaver and nwhitehorn March 4, 2024 23:05
@arahlin arahlin self-assigned this Mar 4, 2024
@cozzyd
Copy link
Contributor

cozzyd commented Mar 5, 2024

update README.rst as well?

@arahlin
Copy link
Member Author

arahlin commented Apr 8, 2024

Bump. @nwhitehorn or @cnweaver is this ok to merge?

Copy link
Member

@nwhitehorn nwhitehorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks great. I don't think anyone is using 2015-era cmake any more.

@arahlin arahlin merged commit 20140cb into master Apr 25, 2024
1 check passed
@arahlin arahlin deleted the update_cmake_version branch April 25, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants