Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler requirements for C++14 #149

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

cnweaver
Copy link
Contributor

@cnweaver cnweaver commented Mar 4, 2024

Follow-up to #148.

@cnweaver cnweaver requested a review from cozzyd March 4, 2024 21:46
@cnweaver cnweaver self-assigned this Mar 4, 2024
Copy link
Contributor

@cozzyd cozzyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those versions seem correct to me, based on docs. This might be slightly painful for EL7 systems that have gcc 4.8 as a default, but it seems reasonable to use a standard 10 years after it is adopted...

@arahlin
Copy link
Member

arahlin commented Mar 5, 2024

those versions seem correct to me, based on docs. This might be slightly painful for EL7 systems that have gcc 4.8 as a default, but it seems reasonable to use a standard 10 years after it is adopted...

EL7 is EOL this year, so this is probably ok. We [SPT] also use clustertools (https://github.com/SouthPoleTelescope/clustertools) with more recent compilers on any EL7 systems anyway.

@arahlin
Copy link
Member

arahlin commented Apr 8, 2024

I think I'm just going to merge this, it's just a README update that isn't going to set any fires.

@arahlin arahlin merged commit be879ce into master Apr 8, 2024
1 check passed
@arahlin arahlin deleted the update-compiler-req-docs branch April 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants