Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force caching of Python_NumPy_FOUND to fix repeated application of cmake #115

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

cnweaver
Copy link
Contributor

This seems to fix #113 .

@cnweaver cnweaver requested a review from arahlin August 17, 2023 23:26
@cnweaver cnweaver self-assigned this Aug 17, 2023
@arahlin
Copy link
Member

arahlin commented Aug 22, 2023

I think longer-term we probably don't want to search for numpy / scipy every time cmake is run, and instead handle these the same way that other packages are handled, but this fix will work for the time being.

@nwhitehorn nwhitehorn merged commit 1b06721 into master Sep 8, 2023
@arahlin arahlin deleted the force-cache-numpy-found branch September 8, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent numpy detection
3 participants