Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/mks_g_series.py many updates: Python 3 only, NAK support, com… #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ejler
Copy link
Member

@Ejler Ejler commented Nov 2, 2023

Updates to mks_g_series.py driver

  • Clean up comm() and checksum(). Now supports Python 3 only (the try: except UnicodeDecodeError to only be a problem in Python 2)
  • The previous commit only works if zeros (noise) are added before/after the MFC response (as was the case on the microreactor setup). A few checks now take care of noise in the comms without hardcoding too much
  • Added NAK support with error message table
  • Added function: read_internal_temperature
    The driver has been tested on the original sniffer setup (Python 3.9.2) and the original microreactor setup (Python 3.5.3) and works consistently on both of them (whereas before it didn't).

…m and checksum cleanup, read internal temperature
@Ejler
Copy link
Member Author

Ejler commented Nov 2, 2023

Will close PR #19

Copy link
Member

@KennethNielsen KennethNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no problems in this, but I also do not have the manual next to me, so consider this just a comment.

PyExpLabSys/drivers/mks_g_series.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants