-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/keithley and cryostat driver updates #68
Draft
robertjensen
wants to merge
21
commits into
master
Choose a base branch
from
feature/keithley_and_cryostat_driver_updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/keithley and cryostat driver updates #68
robertjensen
wants to merge
21
commits into
master
from
feature/keithley_and_cryostat_driver_updates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes a special case for communicating with 2182a via 6220. This should be abstracted somehow.
The old scpi driver is getting very old and pyvisa seems to be a much more well supported kid on the block.
Part of ongoing project to deprecate the scpi class
robertjensen
force-pushed
the
feature/keithley_and_cryostat_driver_updates
branch
from
November 4, 2024 10:02
afee148
to
7e5a0b8
Compare
Also added option to add ramp speed to magnetic field setpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Keithley instruments for improved performance in the Nanomade. Most updates should be universally useful though. A few issues remains before this should be merged, eg the current overly specific handling of 2182a communication via 6220 inside scpi.py needs to be refactored.