Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: a vignette about labelled vectors #208

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

larmarange
Copy link
Contributor

@larmarange larmarange commented Sep 29, 2024

Hi,

I'm genuinely sorry for not having answered sooner. As discussed, I am sharing with you a draft for a vignette about labelled vectors and the labelled package.

This is a draft, so please do not hesitate to tell me how it could be improved.

I was not able to generate the vignette as Sys.getenv("REDCAP_URI") and Sys.getenv("SUPERHEROES_REDCAP_API") are not defined on my computer. So please, do not hesitate to fix the code of the examples if needed.

One again, thank you for your wonderful package and sorry for not having been more reactive.


@rsh52 rsh52 self-assigned this Sep 30, 2024
@rsh52 rsh52 self-requested a review September 30, 2024 15:27
@rsh52 rsh52 added the documentation Improvements or additions to documentation label Sep 30, 2024
@rsh52
Copy link
Collaborator

rsh52 commented Sep 30, 2024

Hi @larmarange, thanks so much for getting around to this! I made a few edits to help with the flow and pointed the vignette at a different test database we use so better display categorical variables since the superheroes database has none (they're all text fields with character strings). Let me know what you think of the edits in the most recent commit and if I missed anything.

I believe the actions are failing because the fork doesn't have access to the GitHub repository secrets so the API calls in the vignettes return errors. This should work fine once we merge to the main branch.

@larmarange
Copy link
Contributor Author

It looks good to me. Thank you very much

Copy link
Collaborator

@rsh52 rsh52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with edits, to approve and confirm actions work on main.

@rsh52 rsh52 merged commit a93d492 into CHOP-CGTInformatics:main Sep 30, 2024
1 of 4 checks passed
@rsh52
Copy link
Collaborator

rsh52 commented Sep 30, 2024

Closing the loop, everything passed and looks good on the pkgdown site!

https://chop-cgtinformatics.github.io/REDCapTidieR/articles/labelled.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants