-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed Structure Data Loss Bug Resolution #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsh52
changed the title
Mixed structure rt rs bug
Mixed Structure Data Loss Bug Resolution
Aug 30, 2024
ezraporter
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted a couple issues in the comments but I think the idea is right!
Co-authored-by: Ezra Porter <[email protected]>
Co-authored-by: Ezra Porter <[email protected]>
Co-authored-by: Ezra Porter <[email protected]>
…GTInformatics/REDCapTidieR into mixed_structure_rt_rs_bug
ezraporter
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Thanks for making those changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a bug found where mixed structure databases outputs may result in data loss in instances where a form may be both "repeating separately" and "repeating together".
Side note: Are there any additional things we should add to the pkgdown site?
Proposed Changes
List changes below in bullet format:
convert_mixed_structure()
field underclean_redcap_long()
to account for missing caseNEWS.md
to be more accurate to present repoScreenshots
If applicable, add screenshots to help explain the proposed changes
Issue Addressed
Closes #200
PR Checklist
Before submitting this PR, please check and verify below that the submission meets the below criteria:
.RDS
) updated underinst/testdata/create_test_data.R
usethis::use_version()
Code Review
This section to be used by the reviewer and developers during Code Review after PR submission
Code Review Checklist