Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citations formatting, authors #174

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

mikemahoney218
Copy link
Contributor

@mikemahoney218 mikemahoney218 commented Feb 14, 2024

Description

Re: openjournals/joss-reviews#6277 , this PR fixes the formatting and authors for a number of citations. I think this is a more correct citation for the badge program, but apologies if it's still incorrect.

Code Review

This section to be used by the reviewer and developers during Code Review after PR submission

Code Review Checklist

  • I checked that new files follow naming conventions and are in the right place
  • I checked that documentation is complete, clear, and without typos
  • I added/edited comments to explain "why" not "how"
  • I checked that all new variable and function names follow naming conventions
  • I checked that new tests have been written for key business logic and/or bugs that this PR fixes
  • I checked that new tests address important edge cases

@mikemahoney218
Copy link
Contributor Author

Tagging @rsh52 -- found a few problems with the current bibtex. You won't need a new archive/release after fixing these.

@rsh52 rsh52 self-requested a review February 14, 2024 17:42
@rsh52 rsh52 self-assigned this Feb 14, 2024
@rsh52
Copy link
Collaborator

rsh52 commented Feb 14, 2024

Tagging @rsh52 -- found a few problems with the current bibtex. You won't need a new archive/release after fixing these.

Ah! Great, thank you so much for updating these. Will merge once checks pass.

@rsh52 rsh52 added the joss Issues related to the JOSS submission label Feb 14, 2024
@rsh52
Copy link
Collaborator

rsh52 commented Feb 14, 2024

I believe the failures are just due to not having env vars the articles require. Going to go ahead with the merge.

@rsh52 rsh52 merged commit 8b8153a into CHOP-CGTInformatics:main Feb 14, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joss Issues related to the JOSS submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants