JOSS Feedback Round 1 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsh52
added
documentation
|
For the time being placed the failing snapshot test in a @spgarbet I believe you already "approved" on the review page, but tagging you for awareness as well. |
ezraporter
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses requests from the first round of reviewer feedback:
redcapAPIcitationREDCapTidieRandredcapAPIcapabilities and specify differencesThe original paper word count according to the JOSS bot was 1189 words (limit in the criteria is supposed to be 1000), and this adds even more. If there's any feedback on things to remove, happy to implement.
This PR closes #168 and closes #167