-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joss paper #166
Joss paper #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Is the paper ready for my review?
I believe so, at least a first pass barring the "Areas for Improvement" I mentioned. |
Hi, I agree with those Areas of Improvement. We should also work in the following:
|
- reference vignettes - reference integration with labelled, openxlsx2, skimr - reference openssf - production deployment nod - table update - new citations
@skadauke Awesome thanks! Let me know if the recent changes address these additions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Added some comments to particular spots but broadly:
- We think about how well-defined the terms in the comparison table are
- We should emphasize even more how life saving
REDCapTidieR
is for working with longitudinal and repeating events
@skadauke Taking another read through the submission criteria just two things that jumped out to me. We may want to convert the Figure 1 caption to text or think of a way to consolidate it so it fits into the link text/brackets: https://joss.readthedocs.io/en/latest/submitting.html#figures-and-images I didn't see any recommendations on captions for tables, so I think we can keep that as is. It's also possible, but I don't personally think necessary, to include a GitHub action for rendering the paper. |
Proposed change for production readiness, at the very least we can lean on these numbers/metrics for the wow-factor. Current:
Proposed:
|
Description
This PR provides a draft for a submission to the Journal of Statistical Software (JOSS).
Areas for improvement:
At present we are just over 800 words, with a max of 1000 per the submission criteria.
Useful References
secuTrialR
Proposed Changes
List changes below in bullet format:
paper.md
andpaper.bib
under the newpaper/
folderpaper/
to.Rbuildignore