Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload multiple artifacts when CI fails #90

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

alejandrobodas
Copy link
Collaborator

Currently, the CI tests only upload one artifact. The second test fails to upload because the artifact name is the same. This change fixes that by uploading one artifact per compiler. This will simplify the review of changes that modify the KGOs.

@alejandrobodas
Copy link
Collaborator Author

Hi @dustinswales , @RobertPincus please can either of you review this change? Thanks!

Copy link
Contributor

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell.

@alejandrobodas
Copy link
Collaborator Author

alejandrobodas commented Mar 21, 2024

Thanks @RobertPincus and @dustinswales . Merging and deleting branch.

@alejandrobodas alejandrobodas merged commit e9add81 into master Mar 21, 2024
10 checks passed
@alejandrobodas alejandrobodas deleted the ci_multiple_artifacts branch March 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants