-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download test data script. #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mvdebolskiy thanks for proposing these changes. I've fixed the CI tests, please can you merge the recent changes into your branch? |
…/download-data
Thanks, it looks good to me. @dustinswales , would you mind reviewing this PR? If you are happy with it, then please go ahead and merge. |
alejandrobodas
approved these changes
Apr 2, 2024
@mvdebolskiy thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updated the links in the
driver/download_test_data.sh
and README.md to be compatible with the github workflow. RunningDoes not give an error.
Added KGO_VERSION env variable `driver/download_test_data.sh similar to github workflow.
Ideally, users should be able to check out multiple kgo versions with the download script. Can remake it as an argument to the script.
Also, added
.gitignore
to ignore all the files created during driver build and download.Issue related: #83