Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download test data script. #84

Merged
merged 20 commits into from
Apr 19, 2024

Conversation

mvdebolskiy
Copy link
Contributor

Just updated the links in the driver/download_test_data.sh and README.md to be compatible with the github workflow. Running

./cosp2_test  cosp2_input_nl.um_global.txt
cd ../
python compare_to_kgo.py data/outputs/UKMO/cosp2_output.um_global.gfortran.kgo.v002.nc data/outputs/UKMO/cosp2_outpu
t.um_global.nc --atol=0.0 --rtol=0.000

Does not give an error.

Added KGO_VERSION env variable `driver/download_test_data.sh similar to github workflow.
Ideally, users should be able to check out multiple kgo versions with the download script. Can remake it as an argument to the script.

Also, added .gitignore to ignore all the files created during driver build and download.

Issue related: #83

@alejandrobodas
Copy link
Collaborator

@mvdebolskiy thanks for proposing these changes. I've fixed the CI tests, please can you merge the recent changes into your branch?

@alejandrobodas alejandrobodas self-requested a review April 2, 2024 10:36
@alejandrobodas
Copy link
Collaborator

Thanks, it looks good to me. @dustinswales , would you mind reviewing this PR? If you are happy with it, then please go ahead and merge.

@alejandrobodas alejandrobodas merged commit 4ee421d into CFMIP:master Apr 19, 2024
5 checks passed
@alejandrobodas
Copy link
Collaborator

@mvdebolskiy thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants