Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code styling #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Code styling #8

wants to merge 3 commits into from

Conversation

kevindb
Copy link
Contributor

@kevindb kevindb commented Sep 25, 2018

Code styling changes to make the code more uniform. I know styling is a matter of preference, and I totally understand if this PR is declined.

  • Removes unnecessary self-closing forward slashes
  • Changes spaced to tabbed indentation
    • Tabs are the prevalent indentation type in the file
  • Uses leadingLowerCamelCase function names

Kevin Morris added 3 commits September 24, 2018 20:37
@atuttle
Copy link
Contributor

atuttle commented Oct 8, 2018

I know that the self-closing tags are not necessary, but I prefer that style. (I have trained my eyes to recognize that it means the next line does not need to be indented another level.)

I'm with you on tabs and camelCase though. If you want to put the self-closing tags back, I'll be happy to click the merge button. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants