Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/leafref linking #108

Closed
wants to merge 2 commits into from
Closed

Conversation

steweg
Copy link
Contributor

@steweg steweg commented Mar 3, 2024

No description provided.

@steweg steweg marked this pull request as ready for review March 3, 2024 21:56
Copy link
Collaborator

@rjarry rjarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

libyang-python only supports the master branch of C libyang (currently 2.x).

The lydevel check is only meant for informative purposes.

libyang-python/tox.ini

Lines 18 to 20 in f09ed11

[testenv:lydevel]
setenv =
LIBYANG_BRANCH=devel

If it fails (currently it should fail because libyang 3.x is under development) it is not a problem.

Could you remove all references to libyang 3 which was not released yet and only focus on the enhancements that you require?

Thank you.

@steweg
Copy link
Contributor Author

steweg commented Mar 29, 2024

Hi,

libyang-python only supports the master branch of C libyang (currently 2.x).

The lydevel check is only meant for informative purposes.

libyang-python/tox.ini

Lines 18 to 20 in f09ed11

[testenv:lydevel]
setenv =
LIBYANG_BRANCH=devel

If it fails (currently it should fail because libyang 3.x is under development) it is not a problem.

Could you remove all references to libyang 3 which was not released yet and only focus on the enhancements that you require?

Thank you.

This feature is actually requires usage of libyang 3.0.X, so this needs to wait till then.

This patch adds leafref_linking context option

Signed-off-by: Stefan Gula <[email protected]>
This patch adds API, which allows user to:
 - determine if DNode is being referenced by some other leafref DNodes.
 - trigger process for creating cross-references between leafref DNodes
   and target DNodes.

Signed-off-by: Stefan Gula <[email protected]>
@steweg steweg requested a review from rjarry May 9, 2024 10:46
samuel-gauthier pushed a commit that referenced this pull request Aug 2, 2024
This patch adds API, which allows user to:
 - determine if DNode is being referenced by some other leafref DNodes.
 - trigger process for creating cross-references between leafref DNodes
   and target DNodes.

Closes: #108
Signed-off-by: Stefan Gula <[email protected]>
Signed-off-by: Samuel Gauthier <[email protected]>
@samuel-gauthier
Copy link
Collaborator

Pushed with minor changes.

@steweg steweg deleted the feature/leafref_linking branch August 3, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants