Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Add PWM and DHT examples #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

luigiluz
Copy link

@luigiluz luigiluz commented Nov 28, 2019

This patch implements two new examples:

i) PWM example: uses PWM to blink a led in a specified time interval.
ii) DHT example: monitor ambient temperature and relative humidity using a DHT sensor.

@ramonhpr ramonhpr requested review from alla3 and vitbaq November 28, 2019 14:25
@ramonhpr ramonhpr added the area: Sample Apps Sample KNoT Apps label Nov 28, 2019
@ramonhpr ramonhpr added this to the Sprint-50 milestone Nov 28, 2019
@luigiluz luigiluz changed the title Add PWM and DHT examples apps: Add PWM and DHT examples Dec 2, 2019
@alla3 alla3 modified the milestones: Sprint-50, Sprint-51 Dec 2, 2019
@luigiluz luigiluz force-pushed the pwmac branch 7 times, most recently from 66ab21c to d3c70f5 Compare January 9, 2020 13:48
Copy link
Collaborator

@vitbaq vitbaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About DHT: It's good to make it clear that it was tested with dht-11. In "apps / dht / prj.conf", dht-11 is set for the example. You can test with dht-22 too and leave commented on that same file. Leave it documented for which DHT works, which dht was tested, which dht the example was made for...

apps/pwm/src/pwm.c Outdated Show resolved Hide resolved
apps/dht/src/dht.c Outdated Show resolved Hide resolved
This patch includes an example that uses PWM to blink a
led in a specified time interval.

Signed-off-by: Luigi Luz <[email protected]>

/*
* This example uses a DHT sensor to monitor ambient temperature and relative
* humidity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain here this example works with dht 11 and dht 22. The default is the dht 11 and the dht 22 can be used by changing the flags on prj.conf file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

This patch includes an example of how to monitor ambient
temperature and relative humidity using a DHT series sensor.

Signed-off-by: Luigi Luz <[email protected]>
@alla3 alla3 requested a review from vitbaq January 28, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sample Apps Sample KNoT Apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants