scripts: cli: Fix blank spaces error in path name #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonhpr
suggested changes
Sep 23, 2019
scripts/cli.py
Outdated
| @@ -189,7 +189,7 @@ def check_env(self): | |||
| logging.info('Using KNoT base path: ' + self.knot_path) | |||
|
|
|||
| # Get current working directory | |||
| self.cwd = os.getcwd() | |||
| self.cwd = os.getcwd().replace(" ","\ ") | |||
There was a problem hiding this comment.
What are you fixing? What is CWD?
Explain what was the problem. The commit message should explain at least what is the problem and what solves it.
There was a problem hiding this comment.
Please use the function https://docs.python.org/2/library/pipes.html#pipes.quote for python 2
or https://docs.python.org/3.4/library/shlex.html#shlex.quote for python 3
humbertowanderley
changed the title
When building inside an application folder with blank space in the folder's name, a path error occurs. Using function 'quote' from shlex library fix this issue. Signed-off-by: Humberto Wanderley <[email protected]>
ramonhpr
approved these changes
Oct 22, 2019
alla3
requested changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing blank spaces with "\ " fix cwd path error.
Signed-off-by: Humberto Wanderley [email protected]