This repository has been archived by the owner on Mar 26, 2022. It is now read-only.
Connect The Client side messaging to the backend #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it will contain logic for all external messaging requests
Needs to be tested with Kumins server
Fixed alot of circular dependcies with the appnotification and apploading
Need to do a major refactoring before moving forward
As the title states, more refactoring needs to be done however
Simply need to handle errors on FB login, Create Pages provider, and finish up messages
Pages are required to be imported into the app.ts
…into connectMessaging
Code is looking very nice, and makes much sense now
All is looking good, simply need to finish up single conversationview to finish messaging
All that remains is message posting (Conversation Create), and message putting (Sending new Message in a conversation)
… when the view enters This will lead to much better UX
Posting messages is now working, but requires some backend fixes, and a toast for newly received messages
Everything working great, with a good UX
torch2424
changed the title
|
@kuminin Ths pull is ready for you! 🍔 |
kuminin
approved these changes
Oct 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #17
However, it opens #45
This allows for Polling for messages from the server, to receive new messages from other users. This also supports POST-ing new messages to the server. This also cleans up ALOT of the front end services, to avoid circular dependencies
gif: