Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 256: Fix wastewater dataset alignment #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaitejohnson
Copy link
Collaborator

This PR closes #256. It breaks the previously used downsample_ww_obs() function into two functions, one which downsamples the entire time series, and another one which truncates the time series according to the prescribed latency at each lab-site pair and the known observation time and nowcast time.

Copy link

github-actions bot commented Nov 25, 2024

Thank you for your contribution @kaitejohnson 🚀! Your github-pages is ready for download 👉 here 👈!
(The artifact expires on 2024-12-02T13:21:50Z. You can re-generate it by re-running the workflow here.)

@kaitejohnson kaitejohnson marked this pull request as ready for review November 25, 2024 17:50
Copy link
Collaborator

@cbernalz cbernalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot fix ww_data and ww_data_eval not consistently sampled
2 participants