-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octopus Tentacle Image #80
Conversation
octopus/Dockerfile.tentacle
Outdated
@@ -0,0 +1,8 @@ | |||
FROM octopusdeploy/tentacle:8.1.1693 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: the newest version is 8.1.1838. These update pretty frequently, but I am also fine leaving it as-is for now. We'll have to come up with an upgrade strategy if/when we ever onboard STLT users to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can push this update along with a name update related to your other comment
${{ inputs.acr_registry }}/dibbs-cloud/octopusdeploy:latest | ||
|
||
- name: Build and push Docker image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we modify this to indicate that it's the tentacle? Or something else to set it apart from the step outlined at line 34?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the files and the terraform plan outputs. The only warning of interest was in the Prod output there are a fewWarning: Value for undeclared variable
warnings. Are these intended to be future variables?
I don't see this as a must to change I was just interested in the intent of the variables. LGTM
I appreciate the call-out, with all the flux in this project, I think they're safe to ignore for now. I'm going to go ahead and merge this. |
Related Issue
Changes Proposed
Additional Information
10933
TargetWorkerPool
to a value that doesn't exist will create a pool or if it needs to be set to a value predefined in Octopus.Testing
Checklist for Primary Reviewer
Infrastructure
terraform-plan
job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!Security
Cloud
dev
environment for verification.