-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: theme checks accross application replaced with central Theme #402
base: main
Are you sure you want to change the base?
Conversation
@BrawlerXull PR is ready to review, let me know if you find any flaw |
Good one @SGI-CAPP-AT2 I'll test it locally and let you know |
Yet there are many instances where old logic is used please refactor it too |
@BrawlerXull , Yes I think We'll need extension to ThemeDatas, |
6431d80
to
a7efea0
Compare
@BrawlerXull , Now you can review and test |
2f74612
to
50511f3
Compare
Will this change also apply to the widget?? ( see #415 ) |
Hey @linuxcaffe , |
@Pavel401 Thanks for sharing, |
84157d8
to
3eb221f
Compare
3eb221f
to
bac8414
Compare
Update: Some of Unexpected changes are fixed now, This PR is ready to test and merge |
Hey thanks for testing, |
@SGI-CAPP-AT2 Can you also fix the calendar theme in the task details page , right now in the dark mode it shows the light theme of the calendar. |
Oh I was using same color scheme for all of the pickers, so I thought it's fixed Let me do that as well |
Fixes: 1. TimePicker themeData 2. Floating action button theme and animation 3. profile page elevated buttons
update: fixes made as per #402 (comment) |
Description
The theme was being managed by checks at each elements local scope to avoid those redundant checks This PR has refactored it with
ThemeExtensions
with ThemeData for dark theme and light themeThese color schemes can be accessed through
Theme.of(context).extensions<TaskwarriorThemeColors>()
.For future color related changes:
Custom Colors to be added inside
TaskwarriorThemeColors
class with common attribute for light and dark.After doing such changes also add colors for corresponding attribute specific to Dark Theme and Light Theme inside
TaskwarriorColors
class.Also fixed following problems:
Fixes #400
closes: #400
closes: #411
Screenshots
Checklist