Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: restore-command and improve value-command #4003

Draft
wants to merge 7 commits into
base: nextgen
Choose a base branch
from
Draft

feat: restore-command and improve value-command #4003

wants to merge 7 commits into from

Conversation

ccetl
Copy link
Contributor

@ccetl ccetl commented Sep 29, 2024

  • Adds a restore command, that restores original values
  • Improves the value command: you now have auto-completion for certain settings and you can use it for sub-settings

@1zun4
Copy link
Member

1zun4 commented Oct 10, 2024

How is the progress on this?

@ccetl
Copy link
Contributor Author

ccetl commented Oct 10, 2024

How is the progress on this?

Done but not tested enough.

@1zun4 1zun4 added this to the 0.17.0 milestone Oct 25, 2024
@1zun4 1zun4 marked this pull request as ready for review October 25, 2024 22:19
@1zun4 1zun4 removed this from the 0.17.0 milestone Oct 26, 2024
1zun4
1zun4 requested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@1zun4 1zun4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has trouble to restore settings in Choices. It can reset the mode back on the default value, but it cannot reset the settings within the modes.

@ccetl
Copy link
Contributor Author

ccetl commented Oct 26, 2024

I think it has trouble to restore settings in Choices. It can reset the mode back on the default value, but it cannot reset the settings within the modes.

Oh and you probably can't change them with the value-command either...

@1zun4 1zun4 marked this pull request as draft December 29, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1zun4 1zun4 1zun4 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccetl @1zun4