Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sort PBACDefaults within their groups #589

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat: Sort PBACDefaults within their groups #589

merged 2 commits into from
Jan 10, 2025

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 9, 2025 •
edited
Loading

Overview

This PR fixes an oversight where the order of the PBAC option must be sorted based on an arbitrary order, rather than the order returned by the API.

Change Details (Specifics)

  • Sort the PBACDefaults within each group by the order property given
  • Update coverage in multiple areas to test this

Related Ticket(s)

N/A

@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 9, 2025
@amattu2 amattu2 marked this pull request as ready for review January 10, 2025 15:50
Alejandro-Vega
Alejandro-Vega approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit de12fa9 into pbac-update-user-roles Jan 10, 2025
3 of 5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the pbac-option-sorting branch January 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0 (PMVP-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega