Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2199 Show Review and Submit in Progress Bar when submit button is visible #585

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

Alejandro-Vega
Copy link
Collaborator

Overview

A Submitter and Federal Lead can submit while a Submission request is in "Submitted" or "Inquired" status. Although, the progress bar for Federal Lead still said "Review" instead of "Review and Submit". Updated logic to show correct title when submit button is visible.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-2199 (Bug)

@Alejandro-Vega Alejandro-Vega added this to the 3.2.0 (PMVP-M3) milestone Jan 7, 2025
@Alejandro-Vega Alejandro-Vega requested a review from amattu2 January 7, 2025 15:09
@coveralls
Copy link
Collaborator

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12675767904

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 56.645%

Totals Coverage Status
Change from base Build 12640941462: 0.04%
Covered Lines: 3833
Relevant Lines: 6319

💛 - Coveralls

amattu2
amattu2 previously approved these changes Jan 7, 2025
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it seems to work perfectly!

I added 2 suggestions, and one question. This can be merged AS-IS if you want.

src/components/ProgressBar/ProgressBar.tsx Show resolved Hide resolved
src/components/ProgressBar/ProgressBar.tsx Show resolved Hide resolved
@amattu2 amattu2 added the 📝 Change Requested This PR has requested changes label Jan 7, 2025
@Alejandro-Vega Alejandro-Vega removed the 📝 Change Requested This PR has requested changes label Jan 8, 2025
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding coverage

@amattu2 amattu2 merged commit 9b15dc8 into 3.2.0 Jan 8, 2025
7 checks passed
@amattu2 amattu2 deleted the CRDCDH-2199 branch January 8, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants