Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2138 Disable "Delete Node Data" button after submit #579

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 3, 2025

Overview

This PR updates the Delete Node Data button (Data View) to disable it in certain submission states. Per KC:

  • Submitted
  • Released
  • Completed
  • Canceled
  • Deleted (I added this)

Note

This bug also needs to go to the backend team so they can update the API.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-2138

@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 3, 2025
@amattu2 amattu2 requested a review from Alejandro-Vega January 3, 2025 14:56
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12599532306

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 56.607%

Totals Coverage Status
Change from base Build 12599259932: 0.008%
Covered Lines: 3830
Relevant Lines: 6315

💛 - Coveralls

Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 44f4998 into 3.2.0 Jan 3, 2025
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-2138 branch January 3, 2025 17:25
@Alejandro-Vega Alejandro-Vega added the Not Run This PR was not tested locally label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants