Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2102 fix: The useProfileFields hook should utilize PBAC #577

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 2, 2025

Overview

This PR updates the useProfileFields hook to utilize PBAC instead of RBAC when determining which fields are unlocked, disabled, etc.

Note

I can't really check this change since the backend won't return data for non-Admins ATM.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-2102 (FE Task)

@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 2, 2025
@amattu2 amattu2 changed the title fix: The useProfileFields hook should utilize PBAC CRDCDH-2102 fix: The useProfileFields hook should utilize PBAC Jan 2, 2025
@amattu2 amattu2 marked this pull request as ready for review January 2, 2025 16:16
@amattu2 amattu2 requested a review from Alejandro-Vega January 2, 2025 16:37
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Didn't test locally.

@Alejandro-Vega Alejandro-Vega added the Not Run This PR was not tested locally label Jan 2, 2025
@Alejandro-Vega Alejandro-Vega merged commit 9db2a7c into pbac-update-user-roles Jan 2, 2025
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-2102-V2 branch January 2, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants