-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-2105 PBAC – Individual Permissions Control of User Accounts #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amattu2
changed the title
CRDCDH-2105
CRDCDH-2105 PBAC – Edit User Individual Permissions Control
Dec 27, 2024
amattu2
changed the title
CRDCDH-2105 PBAC – Edit User Individual Permissions Control
CRDCDH-2105 PBAC – Individual Permissions Control of User Accounts
Dec 30, 2024
Alejandro-Vega
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks solid, and I like the changes you made with separating the PBAC types to their own file. I left a few super small and optional suggestions. Feel free to disregard them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the ability to configure individual PBAC permissions for an account.
Warning
Some known issues / expected things from the backend implementation:
Note
The frontend sorts the groups based on the User Story, but we don't sort the nested permissions themselves since that's somewhat impractical (way too many options).
Change Details (Specifics)
AuthPermissions
to a separate file (PBAC.d.ts
) and createAuthNotifications
type for consistencyAuth.d.ts
if that's preferred, it was just getting clutteredRelated Ticket(s)
CRDCDH-2105 (Task)
... A lot of stories