-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-2099 PBAC - Display Submission Request Action buttons based on permissions #569
Conversation
…t, just log instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, approving as-is. I annotated two questions, but they don't require action.
I'm going to label this as 'Do Not Merge', ideally we should merge the base branch first to keep the change-sets cleaner (once FE/BE are ready).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving – additional changes look good.
Disregard my previous comment on holding the merge. It might make sense to just throw everything into the PBAC PR and do one final comprehensive review before merging.
If you agree, I'll let you merge this PR.
Overview
Update to support PBAC for Submission Request list view as well as the form.
Change Details (Specifics)
Note
For testing, you will have to manually add the permissions array property to your user in the DB.
Related Ticket(s)
CRDCDH-2099 (Task)
CRDCDH-2013 (User Story)