-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-2123 Support "All" studies for Federal Leads #566
Conversation
Pull Request Test Coverage Report for Build 12418541811Details
💛 - Coveralls |
Coveralls is rejecting this PR since it has a significant coverage drop (not really seeing why). Regardless, that can be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM and works great! I left a potential fix for the timing issue regarding the "All" option below. As well as found one potential bug or just a MUI thing. Feel free to disregard both if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Working well with updated changes.
Overview
This PR adds the "All" studies option for Federal Leads on the Edit User tool.
Warning
When switching roles from anything (e.g.
Submitter
) toFederal Lead
, MUI throws a warning because the "All" option is programmatically selected, but not available in the study options during the first render. The only solution I could find that worked is not very clean. I'm open to any alternatives.Change Details (Specifics)
All
option to the Studies list for Federal Leads, selected by defaultVisibleFieldState
out of ProfileView into the useProfileFields hookRelated Ticket(s)
CRDCDH-2123 (Task)