Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Failures #511

Closed
wants to merge 8 commits into from
Closed

Fix Test Failures #511

wants to merge 8 commits into from

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Oct 28, 2024

Overview

PR to address misc testing failures. See details below.

Change Details (Specifics)

  • Fix failures due to incorrectly mocking the env – This setup was failing because of the importing of env.ts instead of just using process.env 6930803
  • Fix failures due to ACT warning – TBD what the cause is...

Related Ticket(s)

N/A

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Oct 28, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11560731505

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.218%

Totals Coverage Status
Change from base Build 11507083842: 0.0%
Covered Lines: 3478
Relevant Lines: 6169

💛 - Coveralls

@amattu2
Copy link
Member Author

amattu2 commented Oct 29, 2024

jestjs/jest#11430

@amattu2

This comment was marked as outdated.

@amattu2
Copy link
Member Author

amattu2 commented Oct 30, 2024

Something is going on with our 508 audits too. See kentcdodds/react-testing-library-course/issues/25

But it's failing as expected in branch CBIIT/crdc-datahub-ui/tree/508-audit-of-forms

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Nov 27, 2024
@amattu2
Copy link
Member Author

amattu2 commented Dec 19, 2024

I'm going to just close this PR for now. I don't have a clean resolution for the act issues. Will revisit this eventually.

@amattu2 amattu2 closed this Dec 19, 2024
@amattu2 amattu2 deleted the ci-test-failures branch December 20, 2024 19:37
@amattu2
Copy link
Member Author

amattu2 commented Dec 26, 2024

Based on recent local testing, this seems to work:

    let result;
    await act(async () => {
      result = await axe(container);
    });
    expect(result).toHaveNoViolations();

As opposed to:

expect(await ...).toHaveNoViolations();

@amattu2 amattu2 restored the ci-test-failures branch December 26, 2024 21:22
@amattu2 amattu2 deleted the ci-test-failures branch December 26, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Do Not Merge This PR is not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants