Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1027 Delete orphan files #362

Merged
merged 50 commits into from
May 16, 2024
Merged

CRDCDH-1027 Delete orphan files #362

merged 50 commits into from
May 16, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented May 7, 2024

Overview

Added ability to delete individual or all orphan files within Validation Results tab. Also, added an additional table pagination to the top of the table.

Change Details (Specifics)

  • Added individual deletion of orphan files within the "Issues" column of the Validation Results table. When clicked, it will delete the orphan file and refresh the table. This uses the Submission.fileErrors to determine orphan files
  • Added bulk/all deletion of orphan files within the "Issues" column of the Validation Results table. When clicked, it will delete all orphan files and refresh the table
  • Added tooltip to the delete all orphan files icon button
  • Updated Validation Results table to have a second pagination section above the table headers
  • Updated filter styling in Validation Results tab and migrated to use the form components select to be consistent

Testing Steps:

  • Upload Data Files via CLI
  • Validate
  • Navigate to Validation Results
  • Observe orphaned file(s) buttons, tooltip, as well as top table pagination. (Delete all orphaned files button will open a dialog)
  • After all orphaned files are deleted, it requires an additional validation to resolve the "Error" state for fileValidationStatus.

Related Ticket(s)

CRDCDH-1027

@Alejandro-Vega Alejandro-Vega added this to the 3.0.0 (PMVP-M1) milestone May 7, 2024
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label May 7, 2024
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label May 16, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review May 16, 2024 16:06
@Alejandro-Vega Alejandro-Vega requested a review from amattu2 May 16, 2024 16:41
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid job and awesome to see component-level test coverage.

Few things annotated below, some of which can be ignored.

Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amattu2 amattu2 merged commit b1ef47e into 3.0.0 May 16, 2024
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-1027 branch May 16, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants